-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resample calibration post-processors with an internal split #894
Conversation
I was thinking a lot about this this morning. Some thoughts not in our google doc:
|
R/grid_code_paths.R
Outdated
# * the model (including the post-processor) generates predictions on the | ||
# assessment set (not internal, i.e. `assessment(split)`) and those | ||
# predictions are assessed with performance metrics | ||
split <- rsample::initial_split(training) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
@@ -373,6 +377,25 @@ tune_grid_loop_iter <- function(split, | |||
|
|||
training <- rsample::analysis(split) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this name just on principle
the first step to being able to use `inner_split()`
With an eye for reducing |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Related to tidymodels/workflows#225, tidymodels/tailor#12.
Code looks something like (updated 5/22/2024):
Previous PR description
This PR proposes resampling calibrators using an "internal split"—it's very scrappy at the moment and intended only for internal testing.
Averaged predictions from the uncalibrated model:
Averaged predictions from the model calibrated internally in tune:
Averaged predictions from the uncalibrated model, calibrated manually
after the fact with probably (I’m not sure I got the flow right with
cal_estimate_linear(...) %>% cal_apply(...)
?):Created on 2024-04-26 with reprex v2.1.0
As-is, this PR doesn't apply any postprocessor if there's not a calibrator in the postprocessor--mostly intended to allow for experimentation on the statistical properties of resampling calibrators in this way.