add rlang type checkers #950
Conversation
| @@ -537,6 +517,7 @@ val_class_or_null <- function(x, cls = "numeric", where = NULL) { | |||
| } | |||
| invisible(NULL) | |||
| } | |||
| # TODO remove this once finetune is updated | |||
There was a problem hiding this comment.
Note to myself and @simonpcouch to make similar changes to finetune so that we can remove these three checking functions
| # ------------------------------------------------------------------------------ | ||
| # acq functions | ||
|
|
||
| check_direction <- function(x) { |
| # ------------------------------------------------------------------------------ | ||
| # acq functions | ||
|
|
||
| check_direction <- function(x) { |
| logical value.", call = call) | ||
| } | ||
| invisible(NULL) | ||
| } |
There was a problem hiding this comment.
TIL that this control option existed😆
| x Fold2: preprocessor 1/1: | ||
| Error in `step_spline_b()`: | ||
| Caused by error in `glue()`: | ||
| ! Expecting '}' |
There was a problem hiding this comment.
I'm seeing this change reverted in the snaps on GHA🤔
There was a problem hiding this comment.
The error we should get is there now; I fixed a bug in recipes that resolved the glue() one. Funny: we were grepping against the glue issue in the logging tests here. I converted it to a snapshot.
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Minimal changes, avoiding
rlang::abort(), cli updates, and call routing 😞