Skip to content

confirm sparsity failure with CRAN recipes #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

simonpcouch
Copy link
Contributor

main workflows GHA, currently with dev recipes, doesn't see an issue with sparsity that the CRAN version does see:

── Failure (test-sparsevctrs.R:219:3): toggle_sparsity changes auto to yes ────
extract_preprocessor(res)$steps[[1]]$sparse (`actual`) not identical to "yes" (`expected`).

`actual`:   "no" 
`expected`: "yes"

recipes 1.1.1 went to CRAN last week. It appears that sometime between a month ago and the recipes CRAN release, this workflows test was broken by recipes, and then since resolved on dev recipes in the last week. Just filing this PR to reproduce this on GHA.

@simonpcouch
Copy link
Contributor Author

Oh, the newest CRAN recipes didn't introduce support for sparsevctrs. See dev NEWS

It's my sense, then, that there's no reason to send #283 to CRAN—the dev changes in workflows right now are almost all related to postprocessing and sparsevctrs, and I had been under the impression that this release was intended to enable sparse workflows.

@simonpcouch
Copy link
Contributor Author

Alright, not an issue. This workflows release will still include sparsity stuff, but recipes patch just isn't triggering sparsity with auto quite yet: 800fb61

Copy link

github-actions bot commented Mar 5, 2025

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant