Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make namespaced functions error if no translation? #1426

Closed
hadley opened this issue Dec 21, 2023 · 0 comments · Fixed by #1432
Closed

Make namespaced functions error if no translation? #1426

hadley opened this issue Dec 21, 2023 · 0 comments · Fixed by #1432

Comments

@hadley
Copy link
Member

hadley commented Dec 21, 2023

i.e. shouldn't this be an error?

library(dbplyr)
library(dplyr, warn.conflicts = FALSE)

lazy_frame(x = 1) |> mutate(x = dplyr::foo(x))
#> <SQL>
#> SELECT foo(`x`) AS `x`
#> FROM `df`

Created on 2023-12-21 with reprex v2.0.2.9000

hadley added a commit that referenced this issue Dec 22, 2023
I'm not sure how this broke, but the code for handling this already exists in `translate_sql()`, so I'm not sure why we started doing some `::` handling in `partial_eval()`.

Fixes #1426
hadley added a commit that referenced this issue Jan 10, 2024
I'm not sure how this broke, but the code for handling this already exists in `translate_sql()`, so I'm not sure why we started doing some `::` handling in `partial_eval()`.

Fixes #1426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant