Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring str_like to dbplyr #509

Closed
rjpat opened this issue Oct 3, 2020 · 4 comments · Fixed by #1075
Closed

Bring str_like to dbplyr #509

rjpat opened this issue Oct 3, 2020 · 4 comments · Fixed by #1075
Labels
feature a feature request or enhancement func trans 🌍 Translation of individual functions to SQL
Milestone
2.3.0

Comments

@rjpat
Copy link

rjpat commented Oct 3, 2020

Currently have str_like() in {stringr}, will add a PR
@rjpat rjpat mentioned this issue Oct 3, 2020
Closed
@rjpat
Copy link
Author

rjpat commented Oct 3, 2020

Realised some problems. Will review and resubmit

@rjpat rjpat mentioned this issue Oct 7, 2020
Closed
@hadley
Copy link
Member

hadley commented Oct 12, 2020

stringr doesn't have a str_like() function?

@rjpat
Copy link
Author

rjpat commented Oct 12, 2020

Sorry should have been more explicit, str_like() is here, there has not been a release since it was merged.

@hadley hadley added feature a feature request or enhancement func trans 🌍 Translation of individual functions to SQL labels Jan 21, 2021
@hadley
Copy link
Member

hadley commented Apr 28, 2022

I clearly totally forgot about str_like(); I'm happy to re-review the PR if you want to re-submit it 😄

@hadley hadley added this to the 2.3.0 milestone Dec 5, 2022
hadley added a commit that referenced this issue Dec 11, 2022
@hadley
Add translations for str_like
58f566f 
Fixes #509
@hadley hadley mentioned this issue Dec 11, 2022
Merged
hadley added a commit that referenced this issue Dec 12, 2022
@hadley
Add str_like() support (#1075)
be41290 
Fixes #509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement func trans 🌍 Translation of individual functions to SQL
Projects
None yet
Milestone
2.3.0
2 participants
@hadley @rjpat