Skip to content

Drop base_symbols #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hadley merged 1 commit into from
Dec 12, 2025
+2 −9
Merged

Drop base_symbols #1675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# dbplyr (development version)

* Redshift: fixed syntax error in `date_build()` translation (#1512).
* dbplyr now longer attempts to translate `pi` to `PI()`. This caused problems if you had a column called `pi` (#1531).
* Ensure `str_like()` and `str_ilike()` have consistent behaviour on SQL Server (@edward-burn, #1669).
* SQL Server: `if`/`ifelse()`, and `if_else()` now use `CASE WHEN` instead of `IIF`. This ensures the handling of `NULL`s matches the R's `NA` handling rules (#1569).
* `if_else()` uses simpler translation for `missing` (#1573).
Expand Down
5 changes: 0 additions & 5 deletions R/backend-.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,11 +360,6 @@ base_scalar <- sql_translator(
str_wrap = sql_not_supported("str_wrap")
)

base_symbols <- sql_translator(
pi = sql("PI()"),
`*` = sql("*"),
`NULL` = sql("NULL")
)
sql_exp <- function(a, x) {
a <- as.integer(a)
if (identical(a, 1L)) {
Expand Down
5 changes: 1 addition & 4 deletions R/translate-sql.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,7 @@ sql_data_mask <- function(
idents <- lapply(names, ident)
name_env <- ceply(idents, escape, con = con, parent = special_calls2)

# Known sql expressions
symbol_env <- env_clone(base_symbols, parent = name_env)

new_data_mask(symbol_env, top_env)
new_data_mask(name_env, top_env)
}

is_infix_base <- function(x) {
Expand Down
Loading