Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Across evaluated lists #817

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Across evaluated lists #817

merged 4 commits into from
Apr 11, 2022

Conversation

mgirlich
Copy link
Collaborator

@mgirlich mgirlich commented Apr 6, 2022

Fixes #660.
Translating lists from the environment could theoretically be a breaking change:

lf %>% mutate(across(a:b, list_formula))

# Before
#> SELECT list_formula(`a`) AS `a`, list_formula(`b`) AS `b`
#> FROM `df`

# After
#> SELECT
#>   `a`,
#>   `b`,
#>   LN(`a`) AS `a_1`,
#>   SUM(`a`) OVER () AS `a_2`,
#>   LN(`b`) AS `b_1`,
#>   SUM(`b`) OVER () AS `b_2`
#> FROM `df`

But this should be quite an irrelevant corner case and the new behaviour is like in dplyr.

@mgirlich mgirlich merged commit d3e5952 into main Apr 11, 2022
@mgirlich mgirlich deleted the across-evaluated-lists branch April 11, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for across in dbplyr and sparklyr
2 participants