-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline select()
after *_join()
#876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Conflicts: R/lazy-join-query.R R/verb-joins.R R/verb-select.R tests/testthat/_snaps/verb-select.md tests/testthat/test-verb-select.R
hadley
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I tried a couple of more exotic join edge cases and the results look great 😄
library(dbplyr)
library(dplyr, warn.conflicts = FALSE)
lf1 <- lazy_frame(x = 1, y = 1, .name = "lf1")
lf2 <- lazy_frame(x = 1, y = 2, .name = "lf2")
lf1 |>
left_join(lf2, by = "x") |>
select(x, y = y.y)
#> <SQL>
#> SELECT `LHS`.`x` AS `x`, `RHS`.`y` AS `y`
#> FROM `lf1` AS `LHS`
#> LEFT JOIN `lf2` AS `RHS`
#> ON (`LHS`.`x` = `RHS`.`x`)
lf1 |>
left_join(lf2 |> rename(z = y), by = "x") |>
select(z)
#> <SQL>
#> SELECT `RHS`.`y` AS `z`
#> FROM `lf1` AS `LHS`
#> LEFT JOIN `lf2` AS `RHS`
#> ON (`LHS`.`x` = `RHS`.`x`)
Created on 2022-08-03 by the reprex package (v2.0.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #866.
left/right/full/inner_join()
before
after
semi/anti_join()
Before
After
Created on 2022-05-18 by the reprex package (v2.0.1)
For
semi/anti_join()
this only works with projections (i.e.select()
andrename()
). In the long run one could mergelazy_semi_join_query()
andlazy_select_query()
assemi_join()
andanti_join()
are simply translated toWHERE (NOT) EXISTS
. But I'd keep them separate for now and explore that at a different time.