Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind_rows() does not check list contents #5417

Closed
lionel- opened this issue Jul 16, 2020 · 2 comments · Fixed by #5502
Closed

bind_rows() does not check list contents #5417

lionel- opened this issue Jul 16, 2020 · 2 comments · Fixed by #5502
Labels
bug an unexpected problem or unintended behavior vctrs ↗️

Comments

@lionel-
Copy link
Member

lionel- commented Jul 16, 2020

before calling new_data_frame():

dplyr::bind_rows(list(x = 1), list(x = 1, y = 1:2))
#> Error: Internal error in `vec_assign()`: `value` should have been recycled to fit `x`.
@lionel- lionel- changed the title vec_rbind() does not check list contents bind_rows() does not check list contents Jul 16, 2020
@StevenMMortimer StevenMMortimer mentioned this issue Aug 16, 2020
Closed
@lionel-
Copy link
Member Author

lionel- commented Aug 17, 2020

This apparently affected @StevenMMortimer. Should use vctrs::data_frame() to transform the lists once next version of vctrs is on CRAN.

@lionel-
Copy link
Member Author

lionel- commented Aug 21, 2020

Should add cases in #5429 as unit tests.

lionel- added a commit to lionel-/dplyr that referenced this issue Aug 28, 2020
@lionel-
Fix data frame initialisation in bind_rows()
1d5ae36 
Closes tidyverse#5417
@lionel- lionel- mentioned this issue Aug 28, 2020
Merged
@hadley hadley added bug an unexpected problem or unintended behavior vctrs ↗️ labels Aug 28, 2020
lionel- added a commit to lionel-/dplyr that referenced this issue Apr 19, 2021
@lionel-
Fix data frame initialisation in bind_rows()
43b5eea 
Closes tidyverse#5417
Closes tidyverse#5749
lionel- added a commit to lionel-/dplyr that referenced this issue Apr 19, 2021
@lionel-
Fix data frame initialisation in bind_rows()
e34ea99 
Closes tidyverse#5417
Closes tidyverse#5749
lionel- added a commit that referenced this issue Apr 19, 2021
@lionel-
Fix data frame initialisation in bind_rows() (#5502)
1526aca 
Closes #5417
Closes #5749

Add unit tests for `bind_rows()`
Contributed by @StevenMMortimer in #5429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior vctrs ↗️
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix data frame initialisation in bind_rows() lionel-/dplyr
2 participants
@hadley @lionel-