Join by named vector #223
Closed
Join by named vector #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #222
The question is what to do about the wrong column order:
i) always use
step_colorder(): this is trivialii) only call
step_colorder()when needed: this makes the code a bit more complicatediii) do not use
merge()but always[to join: this gets rid of the distinction between "simple" and "non-simple" joins and would thus probably simplify the code. This would still sometimes require callingstep_colorder(). It would probably make sense to follow along what is donetidytable. So, if you'd like to go for this option maybe @markfairbanks wants to make a PR for this.