Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typo in filter(.by = ...) error message #611

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Feb 13, 2025

Got this error as I tried replacing the pivoting example in the post.

@maelle maelle requested a review from krlmlr February 13, 2025 09:41
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3a52719 is merged into main:

  • ✔️001_tpch_01: 23.8ms -> 24.6ms [-1.69%, +7.98%]
  • ✔️001_tpch_02: 66.5ms -> 66.2ms [-3.02%, +2.09%]
  • ✔️001_tpch_03: 41.6ms -> 41.3ms [-4.26%, +2.46%]
  • ✔️001_tpch_04: 29.3ms -> 29.5ms [-3.13%, +4.53%]
  • ✔️001_tpch_05: 62.3ms -> 62.4ms [-2.71%, +3.16%]
  • ✔️001_tpch_06: 12.7ms -> 12.3ms [-8.01%, +0.81%]
  • ✔️001_tpch_07: 75.8ms -> 75.8ms [-2.4%, +2.25%]
  • ✔️001_tpch_08: 101ms -> 101ms [-1.61%, +2.14%]
  • ✔️001_tpch_09: 70.8ms -> 71.6ms [-1.35%, +3.69%]
  • ✔️001_tpch_10: 44.7ms -> 44.6ms [-2.67%, +1.92%]
  • ✔️001_tpch_11: 40.8ms -> 40.1ms [-4.48%, +1.01%]
  • ✔️001_tpch_12: 21.6ms -> 21.9ms [-2.44%, +4.47%]
  • ✔️001_tpch_13: 18.6ms -> 18.6ms [-2.47%, +1.61%]
  • ✔️001_tpch_14: 17.3ms -> 17ms [-3.63%, +0.25%]
  • ✔️001_tpch_15: 38ms -> 37.8ms [-2.74%, +1.82%]
  • ✔️001_tpch_16: 36.2ms -> 36.4ms [-2.44%, +3.36%]
  • ❗🐌001_tpch_17: 31.9ms -> 33.1ms [+0.45%, +7.15%]
  • ✔️001_tpch_18: 28.7ms -> 28.8ms [-1.93%, +2.46%]
  • ✔️001_tpch_19: 45.3ms -> 45.4ms [-1.29%, +1.76%]
  • ✔️001_tpch_20: 51.8ms -> 52.7ms [-1.04%, +4.43%]
  • ✔️001_tpch_21: 82.9ms -> 82.5ms [-2.2%, +1.14%]
  • ✔️001_tpch_22: 50.1ms -> 50.1ms [-1.82%, +1.61%]
  • ✔️010_tpch_01: 87.3ms -> 89.6ms [-5.8%, +11.05%]
  • 🚀010_tpch_02: 74ms -> 71.6ms [-6.4%, -0.07%]
  • ✔️010_tpch_03: 59.6ms -> 58.7ms [-5.36%, +2.39%]
  • ❗🐌010_tpch_04: 41.8ms -> 43.2ms [+0.57%, +5.95%]
  • ✔️010_tpch_05: 89.5ms -> 90.4ms [-1.37%, +3.4%]
  • ✔️010_tpch_06: 31.2ms -> 31.8ms [-9.39%, +13.34%]
  • ✔️010_tpch_07: 103ms -> 103ms [-2.24%, +2.44%]
  • ✔️010_tpch_08: 129ms -> 132ms [-1.87%, +6.86%]
  • ✔️010_tpch_09: 117ms -> 117ms [-1.13%, +1.79%]
  • ✔️010_tpch_10: 75.3ms -> 75.1ms [-2.91%, +2.42%]
  • ✔️010_tpch_11: 39.1ms -> 38.3ms [-6.73%, +2.69%]
  • ❗🐌010_tpch_12: 50.6ms -> 53.7ms [+0.83%, +11.48%]
  • ✔️010_tpch_13: 51ms -> 52.7ms [-6.24%, +12.89%]
  • ✔️010_tpch_14: 34.1ms -> 33.9ms [-2.24%, +1.01%]
  • ✔️010_tpch_15: 53.9ms -> 54.1ms [-4.84%, +5.77%]
  • ✔️010_tpch_16: 39.5ms -> 39.9ms [-2.67%, +4.75%]
  • ✔️010_tpch_17: 55.6ms -> 55.5ms [-7.79%, +7.48%]
  • ✔️010_tpch_18: 57.4ms -> 55.3ms [-11.11%, +3.59%]
  • ✔️010_tpch_19: 85.3ms -> 86.9ms [-1.87%, +5.83%]
  • ✔️010_tpch_20: 66.7ms -> 67.6ms [-2.66%, +5.34%]
  • ✔️010_tpch_21: 250ms -> 252ms [-2.46%, +3.73%]
  • ✔️010_tpch_22: 54.5ms -> 54.2ms [-3.55%, +2.42%]
  • ✔️100_tpch_01: 371ms -> 374ms [-7.29%, +9.2%]
  • ✔️100_tpch_02: 128ms -> 130ms [-2.43%, +6.4%]
  • ✔️100_tpch_03: 182ms -> 171ms [-19.3%, +6.81%]
  • ✔️100_tpch_04: 150ms -> 155ms [-5.88%, +12.79%]
  • ✔️100_tpch_05: 262ms -> 272ms [-5.06%, +12.48%]
  • ✔️100_tpch_06: 94.4ms -> 107ms [-0.49%, +28.09%]
  • ✔️100_tpch_07: 228ms -> 225ms [-8.32%, +5.62%]
  • ✔️100_tpch_08: 265ms -> 256ms [-12.73%, +6.59%]
  • ✔️100_tpch_09: 356ms -> 345ms [-10.99%, +4.92%]
  • ✔️100_tpch_10: 216ms -> 211ms [-10.28%, +6.43%]
  • ✔️100_tpch_11: 91.7ms -> 81.8ms [-37.72%, +16.13%]
  • ✔️100_tpch_12: 187ms -> 185ms [-17.56%, +15%]
  • ✔️100_tpch_13: 313ms -> 317ms [-9.93%, +12.37%]
  • ✔️100_tpch_14: 121ms -> 124ms [-20.31%, +24.49%]
  • ✔️100_tpch_15: 197ms -> 203ms [-6.4%, +12.4%]
  • ✔️100_tpch_16: 120ms -> 125ms [-2.81%, +11.04%]
  • ✔️100_tpch_17: 181ms -> 180ms [-12.86%, +11.72%]
  • ✔️100_tpch_18: 192ms -> 197ms [-7.06%, +12.74%]
  • ✔️100_tpch_19: 256ms -> 271ms [-3.33%, +15.38%]
  • ✔️100_tpch_20: 169ms -> 175ms [-8.91%, +16.32%]
  • ✔️100_tpch_21: 1.35s -> 1.35s [-9.1%, +8.87%]
  • ✔️100_tpch_22: 148ms -> 156ms [-0.44%, +11.42%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr changed the title typo? docs: Fix typo in filter(.by = ...) error message Feb 20, 2025
@krlmlr krlmlr merged commit 360090e into main Feb 20, 2025
7 checks passed
@krlmlr krlmlr deleted the maelle-patch-1 branch February 20, 2025 13:18
@krlmlr
Copy link
Member

krlmlr commented Feb 20, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants