Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show source of error if data frame cannot be converted to duck frame #614

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 14, 2025

No description provided.

@krlmlr krlmlr enabled auto-merge (squash) February 14, 2025 10:12
@krlmlr krlmlr changed the title b-error-call-rel-from-df fix: Show source of error if data frame cannot be converted to duck frame Feb 14, 2025
@krlmlr krlmlr merged commit ad1a8dd into main Feb 14, 2025
6 checks passed
@krlmlr krlmlr deleted the b-error-call-rel-from-df branch February 14, 2025 10:23
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 91f70b0 is merged into main:

  • ✔️001_tpch_01: 24ms -> 23.7ms [-5.54%, +3.27%]
  • ✔️001_tpch_02: 66.9ms -> 66.9ms [-2.03%, +2.1%]
  • ✔️001_tpch_03: 41.7ms -> 41.4ms [-2.52%, +1.07%]
  • ✔️001_tpch_04: 28.8ms -> 28.7ms [-1.79%, +1.27%]
  • ✔️001_tpch_05: 58ms -> 58.3ms [-0.46%, +1.58%]
  • ✔️001_tpch_06: 11.8ms -> 11.7ms [-5.48%, +2.18%]
  • ✔️001_tpch_07: 73ms -> 73ms [-1.42%, +1.61%]
  • ✔️001_tpch_08: 98.2ms -> 99ms [-0.54%, +2.15%]
  • ✔️001_tpch_09: 69.5ms -> 69.7ms [-1.3%, +1.99%]
  • ✔️001_tpch_10: 42.7ms -> 42.8ms [-0.74%, +0.94%]
  • ✔️001_tpch_11: 38.6ms -> 38.4ms [-1.98%, +0.87%]
  • ✔️001_tpch_12: 20.9ms -> 21ms [-1.22%, +1.69%]
  • ✔️001_tpch_13: 18.2ms -> 18.1ms [-3.15%, +1.45%]
  • ✔️001_tpch_14: 16.9ms -> 16.7ms [-3.04%, +1.25%]
  • ✔️001_tpch_15: 37.2ms -> 37.2ms [-1.55%, +1.56%]
  • ✔️001_tpch_16: 35.9ms -> 36ms [-1.21%, +1.79%]
  • ✔️001_tpch_17: 32.1ms -> 32.1ms [-1.73%, +1.62%]
  • ✔️001_tpch_18: 28.5ms -> 28.5ms [-1.65%, +1.71%]
  • ✔️001_tpch_19: 44.7ms -> 44.8ms [-1.66%, +2.26%]
  • ✔️001_tpch_20: 51ms -> 51.5ms [-0.39%, +2.04%]
  • ✔️001_tpch_21: 79.4ms -> 79.6ms [-1.31%, +1.73%]
  • ✔️001_tpch_22: 47.2ms -> 47.2ms [-1.29%, +1.4%]
  • ✔️010_tpch_01: 83.8ms -> 86.8ms [-3.12%, +10.31%]
  • ✔️010_tpch_02: 71.2ms -> 71.8ms [-0.75%, +2.43%]
  • ✔️010_tpch_03: 58.8ms -> 58.7ms [-3.76%, +3.48%]
  • ✔️010_tpch_04: 42.8ms -> 42.6ms [-2.27%, +1.23%]
  • ✔️010_tpch_05: 89ms -> 88.8ms [-3.82%, +3.34%]
  • ✔️010_tpch_06: 30.3ms -> 29.7ms [-12.19%, +8.06%]
  • ✔️010_tpch_07: 103ms -> 103ms [-4.28%, +4.06%]
  • ✔️010_tpch_08: 130ms -> 128ms [-4.22%, +0.91%]
  • ✔️010_tpch_09: 117ms -> 118ms [-1.04%, +2.87%]
  • ✔️010_tpch_10: 74.2ms -> 75.1ms [-1.5%, +3.84%]
  • ✔️010_tpch_11: 38.4ms -> 37.4ms [-6.85%, +1.77%]
  • ✔️010_tpch_12: 51.1ms -> 52.4ms [-3.03%, +8.25%]
  • ✔️010_tpch_13: 50.4ms -> 50.9ms [-1.7%, +3.63%]
  • ✔️010_tpch_14: 34.6ms -> 33.7ms [-6.76%, +2.09%]
  • ✔️010_tpch_15: 53.4ms -> 52.1ms [-8.03%, +3%]
  • ✔️010_tpch_16: 39.5ms -> 38.5ms [-6.82%, +1.8%]
  • ✔️010_tpch_17: 52.6ms -> 54ms [-4.26%, +9.57%]
  • ✔️010_tpch_18: 53ms -> 54.2ms [-2.39%, +6.86%]
  • ✔️010_tpch_19: 84.2ms -> 85.3ms [-0.11%, +2.78%]
  • ✔️010_tpch_20: 64.8ms -> 64.1ms [-4.7%, +2.64%]
  • ✔️010_tpch_21: 247ms -> 243ms [-5.01%, +1.82%]
  • ✔️010_tpch_22: 53.6ms -> 53.7ms [-1.73%, +2.29%]
  • ✔️100_tpch_01: 375ms -> 365ms [-14.19%, +8.75%]
  • ✔️100_tpch_02: 125ms -> 124ms [-4.41%, +2.46%]
  • ✔️100_tpch_03: 172ms -> 178ms [-2.74%, +9.6%]
  • ✔️100_tpch_04: 156ms -> 152ms [-11.29%, +6.53%]
  • ✔️100_tpch_05: 285ms -> 266ms [-14.2%, +0.88%]
  • ✔️100_tpch_06: 97.8ms -> 91.7ms [-15.82%, +3.33%]
  • ✔️100_tpch_07: 226ms -> 236ms [-9.24%, +17.93%]
  • ✔️100_tpch_08: 253ms -> 274ms [-1.09%, +18.31%]
  • ✔️100_tpch_09: 323ms -> 319ms [-9.8%, +7.33%]
  • ✔️100_tpch_10: 216ms -> 214ms [-2.77%, +0.87%]
  • ✔️100_tpch_11: 90.8ms -> 99.2ms [-17.22%, +35.88%]
  • ✔️100_tpch_12: 173ms -> 192ms [-2.07%, +24.6%]
  • ✔️100_tpch_13: 328ms -> 319ms [-8.09%, +2.93%]
  • ✔️100_tpch_14: 112ms -> 115ms [-12.96%, +18.37%]
  • ✔️100_tpch_15: 208ms -> 206ms [-11.09%, +8.55%]
  • ✔️100_tpch_16: 115ms -> 125ms [-3.37%, +20.42%]
  • ✔️100_tpch_17: 178ms -> 184ms [-11.6%, +19.06%]
  • ✔️100_tpch_18: 188ms -> 188ms [-9.28%, +8.51%]
  • ❗🐌100_tpch_19: 257ms -> 293ms [+3.09%, +24.97%]
  • ✔️100_tpch_20: 174ms -> 181ms [-12.31%, +21.18%]
  • ✔️100_tpch_21: 1.35s -> 1.35s [-5.42%, +5.17%]
  • ✔️100_tpch_22: 152ms -> 153ms [-2.57%, +3.92%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant