Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScalesList-related functions should be moved into ggproto object #1310

Closed
wch opened this issue Aug 31, 2015 · 1 comment · Fixed by #5144
Closed

ScalesList-related functions should be moved into ggproto object #1310

wch opened this issue Aug 31, 2015 · 1 comment · Fixed by #5144
Labels
feature a feature request or enhancement internals 🔎

Comments

@wch
Copy link
Member

wch commented Aug 31, 2015

There are some functions that operate on ScalesList objects. They should be turned into methods.
@hadley hadley added feature a feature request or enhancement ready labels Jul 28, 2016
@paleolimbot
Copy link
Member

For reference, these functions all (I think) live in R/scales-.r, and are scales_train_df(), scales_map_df(), scales_transform_df(), scales_add_defaults(), and scales_add_missing().

@paleolimbot paleolimbot added the tidy-dev-day 🤓 Tidyverse Developer Day label Jul 7, 2019
@thomasp85 thomasp85 removed the tidy-dev-day 🤓 Tidyverse Developer Day label Apr 30, 2020
@teunbrand teunbrand mentioned this issue Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement internals 🔎
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ScalesList methods teunbrand/ggplot2
4 participants
@hadley @wch @thomasp85 @paleolimbot