Skip to content

Clarify that fullrange = TRUE extends range to the axis limits, not the whole plot. #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gregorp opened this issue Apr 6, 2021 · 0 comments
Labels
documentation good first issue ❤️ good issue for first-time contributors

Comments

@gregorp
Copy link

gregorp commented Apr 6, 2021

There's some understandable confusion about geom_smooth(fullrange = TRUE) not making the smooth line go all the way to the axis lines. (Two example posts on Stack Overflow: 1, 2)

The current argument description in ?geom_smooth is:

fullrange Should the fit span the full range of the plot, or just the data?

I suggest modifying the documentation for clarity, something like this:

fullrange If TRUE, the fit will extend to the axis limits, potentially beyond the data. (It will not extend into the padding of the limits configured by expansion().)

@thomasp85 thomasp85 added documentation good first issue ❤️ good issue for first-time contributors labels Oct 29, 2021
thoolihan added a commit to thoolihan/ggplot2 that referenced this issue Apr 29, 2022
Clearer documentation indicating that fullrange may extend beyond the data but does not fill the area created by expansion.

Docs regenerated by devtools::document() did create some warnings that are unrelated to these changes. Presumably known issues?
thoolihan added a commit to thoolihan/ggplot2 that referenced this issue Apr 29, 2022
Clearer documentation indicating that fullrange may extend beyond the data but does not fill the area created by expansion.

Docs regenerated by devtools::document() did create some warnings that are unrelated to these changes. Presumably known issues?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation good first issue ❤️ good issue for first-time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants