Skip to content

Release ggplot2 3.4.4 #5437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
20 tasks done
teunbrand opened this issue Sep 26, 2023 · 7 comments · Fixed by #5480
Closed
20 tasks done

Release ggplot2 3.4.4 #5437

teunbrand opened this issue Sep 26, 2023 · 7 comments · Fixed by #5480

Comments

@teunbrand
Copy link
Collaborator

teunbrand commented Sep 26, 2023 •
edited
Loading

Prepare for release:

  • git pull
  • Check current CRAN check results
  • Polish NEWS
  • devtools::build_readme()
  • urlchecker::url_check()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • rhub::check_for_cran()
  • revdepcheck::cloud_check()
  • Update cran-comments.md
  • git push

Submit to CRAN:

  • usethis::use_version('patch')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...
@teunbrand
Copy link
Collaborator Author

teunbrand commented Sep 26, 2023 •
edited
Loading

For context, in R-devel is.atomic(NULL) is no longer TRUE.
This hotfix should patch ggplot2 where it relies on that behaviour.

For now, should keep an eye out for when R-devel has introduced the change, so we can test against that change.

This was referenced Sep 26, 2023
Merged
Closed
Merged
@olivroy
Copy link
Contributor

olivroy commented Oct 4, 2023

rgeos should also be removed in the release #5242

@yutannihilation

This comment was marked as outdated.

Sign in to view
@teunbrand
Copy link
Collaborator Author

I have no problem cherrypicking 5484b1d for the release.

@yutannihilation
Copy link
Member

Sorry, it was just that I was confused. Thanks for catching.

@olivroy olivroy mentioned this issue Oct 4, 2023
Merged
@teunbrand teunbrand mentioned this issue Oct 10, 2023
Closed
@teunbrand
Copy link
Collaborator Author

Before merging 3.4.4 into main, we should fix #5478 in the news

@matthewjnield
Copy link
Contributor

I have submitted #5479 to fix #5478.

@teunbrand teunbrand mentioned this issue Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge in v3.4.4 to main tidyverse/ggplot2
4 participants
@yutannihilation @teunbrand @olivroy @matthewjnield