Skip to content

Any identifier with two pairs of consecutive dots is interpreted as calculated aesthetics #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krlmlr opened this issue Jul 6, 2013 · 1 comment
Closed

Any identifier with two pairs of consecutive dots is interpreted as calculated aesthetics #834

krlmlr opened this issue Jul 6, 2013 · 1 comment

Comments

@krlmlr
Copy link
Member

krlmlr commented Jul 6, 2013

Failing:

ggplot() + geom_histogram(aes(x=runif(1000), y=xxx..density..yyy))
## stat_bin: binwidth defaulted to range/30. Use 'binwidth = x' to adjust this.
## Error in eval(expr, envir, enclos) : object 'xxxdensityyyy' not found

Succeeding:

ggplot() + geom_histogram(aes(x=runif(1000), y=d..ensit..y))

Not a real problem, but one with a trivial fix. My favorite :-)
@krlmlr krlmlr mentioned this issue Jul 6, 2013
Closed
@hadley
Copy link
Member

hadley commented Feb 24, 2014

Could you please rebase/merge against master, re-document with the development version of roxygen2 (install_github("klutometis/roxygen) and resubmit?

@hadley hadley closed this as completed Feb 24, 2014
rasmusab pushed a commit to rasmusab/ggplot2 that referenced this issue Feb 25, 2014
@rasmusab
when testing if an identifier refers to a calculated aesthetic, check…
b3d5004 
… the whole identifier, not a substring

also, define the regex that is used for matching only once, in a hidden global variable

fixes tidyverse#834

Conflicts:
	R/layer.r

Resolved by combining.
@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch the regular expression
2 participants
@hadley @krlmlr