Added new function geom_curve #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #' \Sexpr[results=rd,stage=build]{ggplot2:::rd_aesthetics("geom", "curve")} | ||
| #' | ||
| #' @inheritParams geom_point | ||
| #' @param curvature see curveGrob |
There was a problem hiding this comment.
I think @inheritParams grid::curveGrob would be more useful here
|
Overall idea looks good. Also needs a merge/rebase and a bullet point in NEWS |
|
I hope I understood your suggestions correctly. I tried to include everything and did a merge/rebase and updated NEWS. If something still needs to be done, just let me know. |
| @@ -50,6 +53,8 @@ ggplot2 1.0.1.9000 | |||
| * Improved documentation for `aes()` and many geoms and scales. I've tried | |||
| to reduce the use of `...` so that you can see all the documentation in one | |||
| place rather than having to navigate through multiple pages. | |||
| * Added new function geom_curve to add curved lines to plot (similar to | |||
There was a problem hiding this comment.
Looks like something went wrong here - the bullet is duplicated
|
Thanks for your patience. I hope, this time everything is OK. |
|
Looks good - thanks! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.