Change behaviour of theme_update to be more like an update #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 25, 2016 14:16
…g theme_replace that has the same behaviour as the old theme_update. Also expanded and clarified the documentation for these.
|
@wch do you remember the motivation for using |
| #' @export | ||
|
|
||
| theme_replace <- function(...) { | ||
| # Make a call to theme, then add to theme |
There was a problem hiding this comment.
Can you please remove this comment? (and in the previous fun)
|
Looks good. Just a few minor tweaks and can you please add a bullet point to NEWS? |
|
Done! |
| @@ -1,5 +1,9 @@ | |||
| # ggplot2 2.0.0.9000 | |||
|
|
|||
| * `theme_update()` now uses the `+` operator instead of `%+replace%`, so that | |||
| unspecified values will no longer be `NULL`ed out. `theme_replace()` | |||
| preserves the old behaviour if desired (#1519). | |||
There was a problem hiding this comment.
Could you please cite your github user name in the brackets?
|
Done! |
|
Thanks! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #1489, this changes
theme_update()to use the+operator, so that unspecified attributes of the element being set are taken from the current theme, rather thanNULLing them out. I've addedtheme_replace()with the same behaviour as the currenttheme_update(), in case that behaviour is desired (though I'm hard-pressed to think of a use case).I've also added some verbiage to the documentation clarifying what these do, along with examples.