Fix stack and clipping in facets

[thomasp85]

Fixes #1786

[wch]

It looks better but there's still a bit of a 3D look because the line weights aren't the same all the way around the facets.

Using your branch, I ran this code in RStudio on Linux:

p <- ggplot(mtcars, aes(wt, mpg)) +
  geom_point() +
  facet_grid(. ~ am) +
  theme_bw()

# RStudio
p

png('test-png.png', type = 'cairo', width = 300, height = 200)
print(p)
dev.off()

Cairo::CairoPNG('test-CairoPNG.png', width = 300, height = 200)
print(p)
dev.off()

RStudio:

png():

CairoPNG():

[thomasp85]

Hmm... I'm not sure there is anything more I can do from the facet side of things? All panels are clipped and positioned with the lowest z-value (just like before the rewrite)...

If you have time can you try to apply the old theme settings to the new version and see if it all stems from that?

[wch]

Don't let my previous comment stop you from merging if this is the best that can be done - it's still an improvement from the current situation. I don't know if it every looked exactly right.

[thomasp85]

For some reason both cairo calls crashes my machine, but in RStudio the plot is tack-sharp

[thomasp85]

Ok I got it to work. 'cairo' still looks strange but regular png, RStudio itself, pdf etc looks as it should. I'm almost certain that it has something to do with the antialiasing done by cairo - this could be very susceptible to theme tweaks related to line width

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/