Skip to content

Let scales modify title #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2016
Merged

Conversation

thomasp85
Copy link
Member

This PR is mainly justified by the units developers wish to have build in support for the units class in ggplot2. While the scale implementation will be part of ggforce (see the discussion in thomasp85/ggforce#8) some small changes are needed in ggplot2 itself in order to intercept the default scale titles before they are rendered…

@codecov-io
Copy link

Current coverage is 70.41% (diff: 100%)

Merging #1868 into master will not change coverage

@@             master      #1868   diff @@
==========================================
  Files           156        156          
  Lines          5240       5240          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           3690       3690          
  Misses         1550       1550          
  Partials          0          0          

Powered by Codecov. Last update 1709196...afa7a73

@hadley
Copy link
Member

hadley commented Oct 23, 2016

LGTM

I think this would also make it possible to have a scale that automatically divided by 1000, 100000 etc to make the values more readable.

That makes me wonder if the transformer should some how be involved.

@hadley hadley added this to the v2.2.0 milestone Oct 24, 2016
@hadley hadley added the feature a feature request or enhancement label Oct 24, 2016
@hadley
Copy link
Member

hadley commented Oct 24, 2016

Can you add a bullet to NEWS and add to the Scale description?

@thomasp85
Copy link
Member Author

Which scale description? The man page?

I also think this opens up for some niceties in the scales such as what you describe but this is probably best left for the next release/intern

@hadley
Copy link
Member

hadley commented Oct 26, 2016

Yeah, the man for the base class.

Agreed that the rest can wait until the next release.

@thomasp85
Copy link
Member Author

If you look at the documentation level for Scale in ggplot2-ggproto.Rd I think we can agree that a mention there would seem out of place unless the whole section gets an update...

@hadley
Copy link
Member

hadley commented Oct 26, 2016

Oh yeah, let's leave it for now. LGTM

@thomasp85 thomasp85 merged commit cd6a691 into tidyverse:master Oct 26, 2016
@lock
Copy link

lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants