-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Let scales modify title #1868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let scales modify title #1868
Conversation
# Conflicts: # man/ggplot2-ggproto.Rd
Current coverage is 70.41% (diff: 100%)@@ master #1868 diff @@
==========================================
Files 156 156
Lines 5240 5240
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 3690 3690
Misses 1550 1550
Partials 0 0
|
LGTM I think this would also make it possible to have a scale that automatically divided by 1000, 100000 etc to make the values more readable. That makes me wonder if the transformer should some how be involved. |
Can you add a bullet to NEWS and add to the Scale description? |
# Conflicts: # man/ggplot2-ggproto.Rd
Which scale description? The man page? I also think this opens up for some niceties in the scales such as what you describe but this is probably best left for the next release/intern |
Yeah, the man for the base class. Agreed that the rest can wait until the next release. |
If you look at the documentation level for |
Oh yeah, let's leave it for now. LGTM |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This PR is mainly justified by the units developers wish to have build in support for the units class in ggplot2. While the scale implementation will be part of ggforce (see the discussion in thomasp85/ggforce#8) some small changes are needed in ggplot2 itself in order to intercept the default scale titles before they are rendered…