Added linejoin parameter to geom_segment. #2132
Conversation
Ax3man
changed the title
R/geom-segment.r
Outdated
| #' # Use lineend and linejoin to change the style of the segments | ||
| #' df2 <- expand.grid(lineend = c('round', 'butt', 'square'), | ||
| #' linejoin = c('round', 'mitre', 'bevel'), stringsAsFactors = FALSE) | ||
| #' segments <- lapply(seq_len(nrow(df2)), function(i) { |
There was a problem hiding this comment.
This use of lapply() will confuse most readers. Can you please generate with a simple helper function and copy and paste?
There was a problem hiding this comment.
I've simplified this is to a single call to geom_segment, hope that helps.
R/geom-segment.r
Outdated
| #' df2 <- expand.grid(lineend = c('round', 'butt', 'square'), | ||
| #' linejoin = c('round', 'mitre', 'bevel'), stringsAsFactors = FALSE) | ||
| #' df2 <- data.frame(df2, y = 1:9) | ||
| #' ggplot() + |
There was a problem hiding this comment.
Can you please use house indenting rules? (http://style.tidyverse.org/syntax.html#long-lines)
R/geom-segment.r
Outdated
| #' geom_segment(aes(x = 1, y = y, xend = 2, yend = y), df2, size = 4, | ||
| #' lineend = df2$lineend, linejoin = df2$linejoin, | ||
| #' arrow = arrow(length = unit(0.5, "inches"))) + | ||
| #' geom_text(aes(x = 2, y = 1:9, label = paste(df2$lineend, df2$linejoin)), |
There was a problem hiding this comment.
I think you can simplify this plot by setting data and aes(y = y) in the ggplot2 call. The geom_text() layer shouldn't use df$
|
I've simplified to a single |
|
Looks good to me - thanks! |
|
@karawoo can you please merge by hand? |
|
Hello, any chance the linejoin option could also be added to geom_curve? Thank you, Oliver |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This PR simply adds support for the
linejoinparameter ofgrid::segmentsGrobtogeom_segment, just like the existinglineendparameter. This is especially useful when drawing large arrows that need to look sharp. The default of"round"can look poor with filled arrows as all corners are rounded off.The default is the current fixed value.
I'm not sure about the appropriate sizes etc. for the added example as it depends a bit on the size that is drawn for the online docs.