More accurate check for palette names #4093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the names can be NA if more colors are requested than are present in the palette. is_named() would return FALSE in this case, so it's changed here to `!is_null(names(pal))`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4087, specifically the issue where a named palette that didn't match the limits would still get used if too many colors were requested. We now use a more accurate check for whether the palette has names, so if the colors don't match the limits it won't be used. This is the conventional behavior, though as discussed on the issue it can be confusing. This PR makes the behavior consistent, but we might want to separately revisit whether to change the behavior of
scales::manual_pal().