typos; stick to en-GB; prefer project to website #4145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ColorBrewer project name rather than obsolete website name. Not sure what is meant by "use blender variants" in the last example. Should it be "use binned variants"?
|
I don't believe any of the failed checks are related to these minor fixes. |
yutannihilation
requested changes
Jul 25, 2020
| #' colour schemes from ColorBrewer. These are particularly well suited to | ||
| #' display discrete values on a map. See \url{http://colorbrewer2.org} for | ||
| #' more information. | ||
| #' | ||
| #' @note | ||
| #' The `distiller` scales extend brewer to continuous scales by smoothly |
There was a problem hiding this comment.
I feel this should not be removed.
There was a problem hiding this comment.
I removed it because it is repeated later on in the same sentence: "...to a continuous scale." If you read it out loud I think you'll find it is quite wordy / repetitive.
The sentence needs to at least be reworded, as "extends brewer to continuous scales" is not the best wording, in my opinion.
Alternatively:
The
distillerscales are continuous scales created by smoothly interpolating 7 colours from anybrewerpalette.
There was a problem hiding this comment.
Ah, sorry, I missed it. I see.
yutannihilation
approved these changes
Jul 25, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ColorBrewer project name rather than obsolete website name.
Not sure what is meant by "use blender variants" in the last example. Should it be "use binned variants"?