Skip to content

Add oob arguments to date/datetime position scales. #4229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2020
Merged

Add oob arguments to date/datetime position scales. #4229

merged 3 commits into from
Oct 15, 2020

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #4199 by adding oob arguments to date and datetime position scales that are passed along to ggplot2:::datetime_scale().

yutannihilation
yutannihilation approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Could you also add a NEWS bullet for this?

@teunbrand
Copy link
Collaborator Author

Thanks, sure thing!

@yutannihilation yutannihilation merged commit 9741da5 into tidyverse:master Oct 15, 2020
@yutannihilation
Copy link
Member

Thanks!

@teunbrand teunbrand deleted the date_dots branch October 15, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutannihilation yutannihilation yutannihilation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datetime scales don't support out of bounds (oob) arguments
2 participants
@teunbrand @yutannihilation