Skip to content

Fix pkgdown navbar #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Mar 18, 2021

Fix #4376

I'm not sure when the behaviour changed, but it seems pkgdown now requires to list all the topics in structure. At least this works fine on my forked repo:

https://yutannihilation.github.io/ggplot2/dev/

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@thomasp85 thomasp85 merged commit de0b9e3 into tidyverse:master Mar 24, 2021
@yutannihilation yutannihilation deleted the doc/pkgdown-navbar branch March 24, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar on the dev pkgdown site seems broken
2 participants