Warn on unsupported geoms in annotate() #4721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Like with many other PRs at the moment, the failed check is due to a missing package on the 3.3. builder:
|
|
We're actually dropping R 3.3 from the CI at least, so please ignore that failure. |
|
Can you please merge/rebase? |
hadley
reviewed
Mar 14, 2022
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
|
Thank you for reviewing, @hadley! I've applied your suggestions, and resolved the merge conflict. |
hadley
approved these changes
Mar 14, 2022
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
|
Looks like other PRs getting merged keeps causing a conflict in NEWS.md here. Is there any way to avoid that (e.g. does it help if I were to place the changes at the end of the development list rather than at the top), or is it just something you have to live with? |
|
It's just something we live with 😞 |
schloerke
added a commit
to schloerke/ggplot2
that referenced
this pull request
Mar 23, 2022
* master: (320 commits) Orientation-aware key glyphs (tidyverse#4757) Fix warning in geom_violin with draw_quantiles (tidyverse#4654) Fix misalignment in geom_dotplot when stackratio != 1 and stackdir != "up" (tidyverse#4734) Replace coord_equal in scale-identity.r (tidyverse#4759) Unified message format in `geom_smooth()` (tidyverse#4634) Add parentheses to mentions of binned_scale in scale-alpha and scale-viridis documentation (tidyverse#4735) Update geom-boxplot.r (tidyverse#4744) Remove unneeded backslash from diamonds docs (tidyverse#4711) Re-document Warn on unsupported geoms in annotate() (tidyverse#4721) Re-document Add Trump to presidential terms dataset (tidyverse#4702) Corrects bins / binwidth override documentation (tidyverse#4720) Update infrastructure to new best practices (tidyverse#4748) remove stringsAsFactor for the mapped_discrete as.data.frame method (tidyverse#4750) Workflow updates (tidyverse#4747) Ensure output is numeric even if ifelse clause is NA (tidyverse#4692) Add non_missing_aes to geom_tile (tidyverse#4683) Pass on binwidth and height to geom (tidyverse#4671) Check for range == NULL - happens if no data has been added to plot (tidyverse#4682) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference line geoms
geom_abline(),geom_hline()andgeom_vline()not working withannotate()has caused some recurring confusion (at least #1052, #2011, and #4719). Previous issues have been resolved with an acknowledgement, and a recommendation to use the geoms in question directly, instead.To hopefully prevent further confusion, this PR:
annotate()annotate()when unsupported geoms are requestedCloses #4719.