Reset geom/stat defaults #5098
Closed
Reset geom/stat defaults #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realised that the |
|
This is just a note that #5146 conflicts with this PR and either should update according to which one gets merged first. |
Merge branch 'main' of https://github.com/tidyverse/ggplot2 into tidyverse-main # Conflicts: # R/geom-defaults.r # man/update_defaults.Rd # tests/testthat/test-geom-.R
thomasp85
reviewed
May 8, 2023
Merge branch 'main' into geom_defaults # Conflicts: # man/update_defaults.Rd
|
Closing this in favour of #5781. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4993.
In brief, it creates caches for geom/stat defaults that are populated the first time a default is changed with
update_{geom/stat}_defaults(). Then it uses that cache to reset the original defaults whennew = NULL. In addition, the functions invisibly return the previous defaults.I could not find an appropriate unit test for
update_stat_defaults(). The examples also don't includeupdate_stat_defaults()and I'm having a hard time imagining a use case for that function.