Warn when using constant aesthetics #5256
Merged
+30
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5253.
Briefly, it adds a warning when using an all-constant mapping in a layer:
It does take into account inherited aesthetics, so no warning is issued here:
There is an ambiguous case where I was unsure a warning should be emitted. If a layer inherits an aesthetic that it does not use, should the warning been thrown for the aesthetics it does use?
Created on 2023-04-01 with reprex v2.0.2
The
geom_abline()
/geom_vline()
/geom_hline()
are excluded from this check. Extenders can exclude their geoms from this check by using the same exclusion flag (check_constant_aes = FALSE
in the geom's ggproto fields).