Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set vjust = 1 for axis.title.y.right. #5629

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

teunbrand
Copy link
Collaborator

This cold PR aims to fix an informally discussed issue.

Briefly, the current axis.title.y.right rotation is -90° and has vjust = 0. This puts it in the position closest to the plot panel.
Meanwhile, axis.title.y.left rotation = 90° and has vjust = 1, placing it the furthest away from the plot panel.
To harmonise their behaviour relative to the panel and place both axes the furthest away, this PR gives axis.title.y.right also vjust = 1.

@teunbrand teunbrand changed the base branch from main to rc/3.5.0 January 5, 2024 10:04
@teunbrand teunbrand added this to the ggplot2 3.5.0 milestone Jan 5, 2024
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 78125e0 into tidyverse:rc/3.5.0 Jan 5, 2024
@teunbrand teunbrand deleted the axis_title_vjust branch January 5, 2024 10:53
thomasp85 pushed a commit that referenced this pull request Feb 23, 2024
* change right axis title vjust

* accept visual changes

* Add news bullet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants