Do not use class information for raster resolution calculation #5638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to the RC aims to fix a bug uncovered during reverse dependency checks.
When feeding continuous data to
geom_raster()
but using discrete scales confers themapped_discrete
class even upon the continuous data. We use the heuristic thatmapped_discrete
values have resolution 1 in #5247. This leads to problems ingeom_raster()
:In this PR, the data of
geom_raster()
isunclass()
'ed so thatresolution
correctly pick up on its continuous nature:I found out about this using case via the breakage of stars, where the following example would consume gigabytes of memory due to building an enormous raster. With this PR, this is now more in sync with the size of the original data.
Created on 2024-01-12 with reprex v2.0.2