Skip to content

Fill in missing se parameter #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2024
Merged

Fill in missing se parameter #5700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f2572f
fill in missing `se`
teunbrand Feb 22, 2024
638034f
account for flipped aesthetics
teunbrand Feb 22, 2024
daed686
add news bullet
teunbrand Feb 23, 2024
ea04e05
Merge branch 'main' into smooth_se
teunbrand May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# ggplot2 (development version)

* The default `se` parameter in layers with `geom = "smooth"` will be `TRUE`
when the data has `ymin` and `ymax` parameters and `FALSE` if these are
absent. Note that this does not affect the default of `geom_smooth()` or
`stat_smooth()` (@teunbrand, #5572).
* The bounded density option in `stat_density()` uses a wider range to
prevent discontinuities (#5641).
* `geom_raster()` now falls back to rendering as `geom_rect()` when coordinates
Expand Down
7 changes: 7 additions & 0 deletions R/geom-smooth.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@ geom_smooth <- function(mapping = NULL, data = NULL,
GeomSmooth <- ggproto("GeomSmooth", Geom,
setup_params = function(data, params) {
params$flipped_aes <- has_flipped_aes(data, params, range_is_orthogonal = TRUE, ambiguous = TRUE)
params$se <- params$se %||%
if (params$flipped_aes) {
all(c("xmin", "xmax") %in% names(data))
} else {
all(c("ymin", "ymax") %in% names(data))
}

params
},

Expand Down