Copy angle heuristic for more guides. #5957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into angle_heuristic
teunbrand
commented
Jul 11, 2024
Comment on lines
+579
to
+588
| # Taking the sign of the (co)sine snaps the value to c(-1, 0, 1) | ||
| # Doing `x / 2 + 0.5` rescales it to c(0, 0.5, 1), which are good values for justification | ||
| # The rounding step ensures we can get (co)sine to exact 0 so it can become 0.5 | ||
| # which we need for center-justifications | ||
| cosine <- sign(round(cos(radian), digits)) / 2 + 0.5 | ||
| sine <- sign(round(sin(radian), digits)) / 2 + 0.5 | ||
|
|
||
| # Depending on position, we might need to swap or flip justification values | ||
| hjust <- switch(position, left = cosine, right = 1 - cosine, top = 1 - sine, sine) | ||
| vjust <- switch(position, left = 1 - sine, right = sine, top = 1 - cosine, cosine) |
There was a problem hiding this comment.
I'm very pleased with this bit replacing a whole slew of nested if blocks.
cyclocomp::cyclocomp() says complexity has been reduced from 28 to 8 (>15 is generally considered 'too complex').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4594.
Briefly it copies the heuristic from
guide_axis(angle)to the following guides:guide_colourbar(),guide_coloursteps()andguide_bins().Note that angle heuristic is applied in
GuideLegend$override_elements()even though GuideLegend does not use the heuristic (per #4594 (comment)). While not applied in GuideLegend, it is inherited by and used in child guides.Some examples. Note that for labels placed close to the edge (1st example '6000'), the label may escape the allocated space, but there is no easy fix for this at the moment.
Created on 2024-06-25 with reprex v2.1.0