Flexible palettes #6216
Merged
Flexible palettes #6216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Includes fix for #6289, since it'd touch the same code. |
thomasp85
requested changes
Feb 27, 2025
Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com>
thomasp85
reviewed
Mar 25, 2025
R/scale-colour.R
Outdated
|
|
||
| has_old_args <- any(names(enexprs(...)) %in% c("h", "c", "l", "h.start", "direction")) | ||
|
|
||
| if (has_old_args || !is.null(type) && is.null(palette)) { |
There was a problem hiding this comment.
I know I'm being pedantic here but please make the same changes to the logic tests here and below :-)
There was a problem hiding this comment.
Ah my bad, I should've spotted these!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6064 and fix #4910 and fix #6289 and fix #5843 and replaces #6112.
Briefly, it attempts to cast non-null
palettearguments withas_discrete_pal()/as_continuous_pal(). These are currently shims.This PR replaces the older one because I could implemented more cleanly now that #5946 is merged.