Skip to content

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #6320.

Instead of setting panel.grid.major and panel.grid.minor to blank, we set the parent panel.grid to blank.

Reprex from issue:

devtools::load_all("~/packages/ggplot2/")
#> ℹ Loading ggplot2

p <- ggplot(mpg, aes(displ, hwy)) +
  geom_point() +
  theme_classic()

p + theme(panel.grid = element_line(colour = "limegreen"))

Created on 2025-02-05 with reprex v2.1.1

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 1f3fc2e into tidyverse:main Mar 25, 2025
13 checks passed
@teunbrand teunbrand deleted the theme_classic_grid branch March 25, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

theme_classic() panel grid should be set blank at parent

2 participants