add accent argument to theme_grey, theme_minimal, etc
#6438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this addresses most of making accent accessibility from the built in theme functions. Do need to check on theme_void
teunbrand
requested changes
Apr 25, 2025
There was a problem hiding this comment.
Hi Gina, thank you so much for the PR! There are a few things that I think should be tweaked. One is in the comment, the other is whether you can run devtools::document() to propagate changes from the @param description to the .Rd files. In other aspects this looks great!
Comment on lines
+541
to
+547
| geom = element_geom( | ||
| ink = ink, paper = paper, accent = accent, | ||
| linewidth = base_line_size, borderwidth = base_line_size, | ||
| linetype = 1L, bordertype = 1L, | ||
| family = base_family, fontsize = base_size, | ||
| pointsize = (base_size / 11) * 1.5, pointshape = 19 | ||
| ), |
There was a problem hiding this comment.
I think this changed something in the visual test (for the better). We might have to update the snapshot for theme-void-large.svg accordingly.
|
Just a comment for linking purposes, that this PR would fix #6414. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed making
accent(e.g. geom_smooth's blue) accessible from the built-in convenience theme functions liketheme_grey,theme_minimaletc. Most of the changes are pretty minimal, but fortheme_void, it seems thatgeom = element_geom(...should be added so that that the new geom dimension of theme can be manipulated fromtheme_void()