Skip to content

Adapt to scales 1.4.0 #6441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged

Adapt to scales 1.4.0 #6441

merged 5 commits into from
Apr 25, 2025

Conversation

teunbrand
Copy link
Collaborator

@teunbrand teunbrand commented Apr 25, 2025

This PR aims to fix #6172.

It implements the two remaining items on the list in the issue.
Most of this PR are just tiny changes in colour mixing proportions to preserve the hex code.
One visual test changed, but that is fine as that theme option wasn't available in previous versions, so there isn't anything to preserve really.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 61b9ebc into tidyverse:main Apr 25, 2025
13 checks passed
@teunbrand teunbrand deleted the adapt_scales_140 branch April 25, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming scales 1.4.0 release
2 participants