Skip to content

enable continuous integration via craigcitro/r-travis #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

enable continuous integration via craigcitro/r-travis #872

wants to merge 2 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 7, 2013

  • install binary R packages where available
  • supply .gitignore

Kirill Müller added 2 commits November 1, 2013 18:16
- install binary R packages where available
@krlmlr
Copy link
Member Author

krlmlr commented Dec 12, 2013

@hadley: This might help addressing the issues raised in your earlier comment. Let me know if I can help by enhancing this PR.

All in all, I think people will accept visual changes if they are documented appropriately. tikzDevice has visual integration tests that compare results at the pixel level. I see save_vtest in your code, and the vtest package. What do I need to do to activate the visual tests? What is so onerous about them (or about testing ggplot2 in general)?

I haven't looked into vtest yet, but I would compare images at the following levels:

  • PDF output, to check that results are identical
  • Output of tikzDevice, to check if individual grobs have moved/changed
  • PNG output, to see how severe the change is visually

GitHub has a nice GUI for comparing images.

@hadley hadley closed this in 94161f5 Feb 24, 2014
@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant