Fix vertical justification for rotated text

[krlmlr]

The computation for x (or y) values based on vjust values does not work correctly for all cases. I have shown an example before and after applying this change.

Before

Everything looks good by default

library(ggplot2)

## Loading required package: methods

library(grid)

(p <- qplot(diamonds$cut, binwidth=0.5) + theme_bw(24) +
   theme(axis.text.x=element_text(vjust=0.5)))
showViewport()

Now play with the justification:

(p0 <- p + theme(axis.title=element_text(vjust=0)))
showViewport()

And the other extreme:

(p1 <- p + theme(axis.title=element_text(vjust=1)))
showViewport()

Top-down:

p0 + theme(axis.title.x=element_text(angle=180), axis.title.y=element_text(angle=270))
showViewport()

Top-down, vjust==1:

p1 + theme(axis.title.x=element_text(angle=180), axis.title.y=element_text(angle=270))
showViewport()

This is inconsistent.

After

Everything looks good by default

library(ggplot2)

## Loading required package: methods

library(grid)

(p <- qplot(diamonds$cut, binwidth=0.5) + theme_bw(24) +
   theme(axis.text.x=element_text(vjust=0.5)))
showViewport()

Now play with the justification:

(p0 <- p + theme(axis.title=element_text(vjust=0)))
showViewport()

And the other extreme:

(p1 <- p + theme(axis.title=element_text(vjust=1)))
showViewport()

Top-down:

p0 + theme(axis.title.x=element_text(angle=180), axis.title.y=element_text(angle=270))
showViewport()

Top-down, vjust==1:

p1 + theme(axis.title.x=element_text(angle=180), axis.title.y=element_text(angle=270))
showViewport()

Source

#-echo=F
library(knitr)
opts_chunk$set(fig.height=4)
opts_knit$set(upload.fun = imgur_upload)

#' Everything looks good by default
library(ggplot2)
library(grid)

(p <- qplot(diamonds$cut, binwidth=0.5) + theme_bw(24) +
   theme(axis.text.x=element_text(vjust=0.5)))
showViewport()

#' Now play with the justification:
(p0 <- p + theme(axis.title=element_text(vjust=0)))
showViewport()

#' And the other extreme:
(p1 <- p + theme(axis.title=element_text(vjust=1)))
showViewport()

#' Top-down:
p0 + theme(axis.title.x=element_text(angle=180), axis.title.y=element_text(angle=270))
showViewport()

#' Top-down, `vjust==1`:
p1 + theme(axis.title.x=element_text(angle=180), axis.title.y=element_text(angle=270))
showViewport()

#' This is inconsistent.

[hadley]

Could you please rebase/merge against master, re-document with the development version of roxygen2 (install_github("klutometis/roxygen) and resubmit?

[krlmlr]

Force-pushed to the same. Could you please re-open and merge this pull request?

[hadley]

Actually could you please resubmit the PR? Then travis will get run.

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/