New themes panel.margin.x and panel.margin.y

[krlmlr]

Re-issue of #840.

[hadley]

• Motivate the change in one paragraph, and include it in NEWS.
  In parenthesis, reference your github user name and this issue:
  (@hadley, #1234)
• Check pull request only includes relevant changes.
• Use the official style.
• Update documentation and re-run roxygen2
• Add minimal example, if new graphical feature

[krlmlr]

Do you want a separate pull request for the mini-fix?

[hadley]

I'll do it.

[krlmlr]

If you could cherry-pick it, this pull request still would be valid.

[hadley]

I don't think we need to bother for this problem, but in the future, it really helps if I can accept a pull request as is, without having to use the command line. That's the point I'm trying to get to with travis, testthat, vtest etc.

[hadley]

Can you please remind me the easiest way to merge this with git/hub?

[krlmlr]

I think it was hub merge https://github.com/hadley/ggplot2/pull/914. Merging instructions also come with each pull request e-mail, but the former might also close the pull request on GitHub (never used it myself).

I'd still like to add a visual test, could you please point me at documentation?

[hadley]

Ok, let wait until next week then.

[hadley]

Decided to merge before new visual tests - I think that's going to have to wait a while.

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/