Rebased version of continuous brewer color scales #925
Conversation
It fetches 6 colours from a colorbrewer palette and feeds them to gradientn. It gives very nice results even if the palettes were not intended for that use originally.
As per Hadley's request: "add a few words to the main doc mentioning that it does both continuous and discrete variables""
Give more precisions regarding the intent of the original colours and how ggplot2 modifies them (in the continuous case).
| @@ -1,9 +1,20 @@ | |||
| #' Sequential, diverging and qualitative colour scales from colorbrewer.org | |||
| #' | |||
| #' Create colour scales based on ColorBrewer colours. | |||
There was a problem hiding this comment.
Do you need this line? Could it be combined with the title above?
|
|
I should say, by and large all these pull requests look great - thanks! And please let me know what you think of the new process. |
Add spaces around `=`
The actual function call from which the warning is emitted might not be that helpful to the casual user.
|
You're welcome. I think the new process is good. It's a bit more work for submitters of course but ensures better quality in the final code. It really makes it necessary to have a feature branche per pull-request though. You may want to emphasise this even more in the wiki/doc. I like the checklist! Is that automated? |
Rebased version of continuous brewer color scales
|
It's not automated, it just reminds me the things that I need to check. Have you seen the new development vignette? It tries to lay out the best practices, like using a branch per request. |
|
I don't remember seeing the vignette, just some indication on the wiki. The vignette is indeed ~ how I do it and it works great. |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
No description provided.