Unterminated comments error now

Instead of generating an empty string. Closes #224.
tidyverse · Sep 25, 2021 · 1fbb9a3 · 1fbb9a3
1 parent c9f9cf9
commit 1fbb9a3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/glue.c b/src/glue.c
@@ -182,6 +182,9 @@ SEXP glue_(SEXP x, SEXP f, SEXP open_arg, SEXP close_arg) {
   } else if (state == double_quote) {
     free(str);
     Rf_error("Unterminated quote (\")");
+  } else if (state == comment) {
+    free(str);
+    Rf_error("Unterminated comment");
   }
 
   free(str);

diff --git a/tests/testthat/test-glue.R b/tests/testthat/test-glue.R
@@ -429,3 +429,10 @@ test_that("unterminated quotes are error", {
   expect_error(glue("{this doesn\"t work}"), "Unterminated quote")
   expect_error(glue("{this doesn't work}"), "Unterminated quote")
 })
+
+test_that("unterminated comment", {
+  expect_error(glue("pre {1 + 5 # comment} post"), "Unterminated comment")
+  expect_error(glue("pre {1 + 5 # comment"), "Unterminated comment")
+
+  expect_equal(glue("pre {1 + 5 + #comment\n 4} post"), "pre 10 post")
+})