Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should an unpaired quote throw an error? #219

Closed
gaborcsardi opened this issue Aug 16, 2021 · 3 comments
Closed

Should an unpaired quote throw an error? #219

gaborcsardi opened this issue Aug 16, 2021 · 3 comments

Comments

@gaborcsardi
Copy link
Member

Probably. Cf. r-lib/cli#333

❯ str(glue::glue("{this doesn't work}"))
 'glue' chr ""

❯ str(glue::glue("{this does not work}"))
Error in parse(text = text, keep.source = FALSE) :
  <text>:1:6: unexpected symbol
1: this does
@gaborcsardi
Copy link
Member Author

@jimhester would you review a PR for this?

@jimhester
Copy link
Collaborator

yeah

gaborcsardi added a commit that referenced this issue Sep 25, 2021
@gaborcsardi
Make untermiated quotes error
c9f9cf9 
Closes #219.
gaborcsardi added a commit that referenced this issue Sep 25, 2021
@gaborcsardi
Make untermiated quotes error
2c9459b 
Closes #219.
@gaborcsardi
Copy link
Member Author

This is now fixed in #226 I believe..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimhester @gaborcsardi