Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBI::SQL() elements should be collapsed correctly #192

Merged
merged 2 commits into from
Jun 4, 2020
Merged

DBI::SQL() elements should be collapsed correctly #192

merged 2 commits into from
Jun 4, 2020

Conversation

shrektan
Copy link
Contributor

@shrektan shrektan commented Jun 3, 2020

Closes #191

This is a regression of commit 1867133

@shrektan
Copy link
Contributor Author

shrektan commented Jun 4, 2020

Looks like the checking errors have nothing to do with the PR itself.

@jimhester
Copy link
Collaborator

Looks good, thanks!

@jimhester jimhester merged commit a768e8a into tidyverse:master Jun 4, 2020
@shrektan shrektan deleted the fix191 branch June 4, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

glue_sql() changed behavior for vectorized DBI::SQL() elements
2 participants
@shrektan @jimhester