Fix issue with read_dta crashing R #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woops, missed one, also fixes #594 |
|
Yeah, lets make it |
|
No worries, done! I'm not much of a C person so it feels super hacky, but it works 😛 |
hadley
reviewed
Jul 26, 2021
src/DfReader.cpp
Outdated
|
|
||
| if (readstat_value_is_tagged_missing(value)) { | ||
| col[obs_index] = NA_STRING; | ||
| } else if (!user_na_ && readstat_value_is_defined_missing(value, variable)) { | ||
| col[obs_index] = NA_STRING; | ||
| } else if (readstat_value_is_system_missing(value)) { | ||
| col[obs_index] = NA_STRING; | ||
| } else if (str_value == NULL) { | ||
| const char empty_string[1] = { '\0' }; | ||
| col[obs_index] = cpp11::r_string(empty_string); |
There was a problem hiding this comment.
Can't you just do cpp11::r_string("") ?
There was a problem hiding this comment.
Haha yep! Too much time in R treating "" and '' as equivalent 🤦
|
Thanks for working on this! Will prepare a release next week some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updates for cpp11 reintroduced the bug in #79 when read_dta is used on a file that has empty values in an StrL variable (#600, #608). This PR restores the old behaviour and returns an NA for these observations.
@hadley, the StrL section of the dta spec says that a NULL (i.e. no StrL address) should be interpreted as the empty string
""rather than a missing value, soNA_STRINGmight not actually be the most appropriate value here (although it would be consistent with previous versions of haven).What do you think?