Changed Duration format to correctly display negative values #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gative values.
…h negative values Negative durations were not being printed properly; they looked positive. This one line addition prepends a negative sign to durations created from negative values. When the package is tested I get 4 failures, but I get these same 4 failures with no changes to the package code. So, I'm unsure how to resolve this.
…e_estimate as in original package code
hadley
changed the title
|
If, you're interested in finishing this off, would you mind add a small unit test? No worries, if you're not, just let me know and I'll get it over the finish line for you. |
|
I can definitely put a unit test together for this! Thanks for taking a look. Would you mind if I don't get to it for a couple of days? If you do, then I'm perfectly happy for you to take it over the finish line...I don't want to hold anything up. |
|
No rush! |
vspinu
reviewed
Nov 28, 2019
| @@ -101,6 +101,7 @@ format.Duration <- function(x, ...) { | |||
| out <- vector("character", length(x@.Data)) | |||
| nnas <- !is.na(x@.Data) | |||
| out[nnas] <- compute_estimate(abs(x@.Data[nnas])) | |||
| out[nnas] <- ifelse(x@.Data[nnas] < 0, paste0("-", out[nnas]), out[nnas]) | |||
There was a problem hiding this comment.
I think this negative sign should be handled in compute_estimate instead and that abs removed.
|
I have fixed this at the root in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #719