Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rlang reconciliation #320

Closed
5 of 13 tasks
hadley opened this issue May 3, 2017 · 5 comments
Closed
5 of 13 tasks

rlang reconciliation #320

hadley opened this issue May 3, 2017 · 5 comments
Labels
feature a feature request or enhancement lifecycle 🦋

Comments

@hadley
Copy link
Member

hadley commented May 3, 2017

Need to resolve inconsistencies, and make sure only lives in one place. (purrr should probably re-export)

  • set_names()
  • invoke()
  • rep_along()
  • predicate functions
  • %||%
  • purrr::as_function() (defunct in purrr 0.3.0)
  • %@% (soft-deprecated in purrr 0.3.0)
  • list_along() (soft-deprecated in rlang 0.2.0)
  • modify() (questioning in rlang 0.3.0)
  • prepend() (questioning in rlang 0.3.0)
  • flatten() (vctrs milestone)
  • squash() (vctrs milestone)
  • splice()
@hadley hadley changed the title set_names is now in rlang rlang reconciliation May 8, 2017
hadley added a commit that referenced this issue Jun 26, 2017
hadley added a commit that referenced this issue Jun 26, 2017
@lionel-
Copy link
Member

lionel- commented Jul 4, 2017

There's also the flatten() functions, which have slightly richer semantics in rlang. And purrr could gain the squash() family as well (recursive flattening).

@hadley hadley added the feature a feature request or enhancement label Feb 4, 2018
@hadley
Copy link
Member Author

hadley commented Oct 2, 2018

> conflict_scout(c("purrr", "rlang"))
14 conflicts:
* `%@%`        : purrr, rlang
* `%||%`       : purrr, rlang
* `as_function`: purrr, rlang
* `flatten`    : purrr, rlang
* `flatten_chr`: purrr, rlang
* `flatten_dbl`: purrr, rlang
* `flatten_int`: purrr, rlang
* `flatten_lgl`: purrr, rlang
* `invoke`     : purrr, rlang
* `list_along` : purrr, rlang
* `modify`     : purrr, rlang
* `prepend`    : purrr, rlang
* `rep_along`  : purrr, rlang
* `splice`     : purrr, rlang

lionel- added a commit to lionel-/lowliner that referenced this issue Nov 22, 2018
lionel- added a commit to lionel-/lowliner that referenced this issue Nov 23, 2018
lionel- added a commit that referenced this issue Dec 11, 2018
@lionel-
Copy link
Member

lionel- commented Dec 11, 2018

purrr's %@% needs to be soft-deprecated instead of reexported because unlike rlang's, it uses a non-NSE implementation.

lionel- added a commit that referenced this issue Dec 11, 2018
The rlang version is more consistent with `@`

Part of #320
lionel- added a commit that referenced this issue Dec 21, 2018
lionel- added a commit to r-lib/rlang that referenced this issue Jun 11, 2019
@hadley
Copy link
Member Author

hadley commented Aug 24, 2022

As of today:

conflicted::conflict_scout(c("purrr", "rlang"))
#> 10 conflicts:
#> * `%@%`        : purrr, rlang
#> * `as_function`: purrr, rlang
#> * `flatten`    : purrr, rlang
#> * `flatten_chr`: purrr, rlang
#> * `flatten_dbl`: purrr, rlang
#> * `flatten_int`: purrr, rlang
#> * `flatten_lgl`: purrr, rlang
#> * `flatten_raw`: purrr, rlang
#> * `invoke`     : purrr, rlang
#> * `splice`     : purrr, rlang

Created on 2022-08-24 by the reprex package (v2.0.1)

@hadley
Copy link
Member Author

hadley commented Sep 8, 2022

So I think we're done here.

@hadley hadley closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement lifecycle 🦋
Projects
None yet
Development

No branches or pull requests

2 participants