-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate cross()
and cross_df()
#768
Labels
breaking change ☠️
API change likely to affect existing code
Comments
This was referenced Jun 5, 2020
jpdunc23
referenced
this issue
in Yu-Group/simChef
Dec 28, 2022
christianrickert
added a commit
to himsr-lab/phenoptrReports
that referenced
this issue
Nov 5, 2023
``` ── Warning (test_smoke.R:136:3): file generation works ───────────────────────── `cross2()` was deprecated in purrr 1.0.0. i Please use `tidyr::expand_grid()` instead. i See <tidyverse/purrr#768>. ```
christianrickert
added a commit
to himsr-lab/phenoptr
that referenced
this issue
Nov 10, 2023
``` -- Warning (test_average_counts.R:87:3): count_within_many works --------------- `cross()` was deprecated in purrr 1.0.0. i Please use `tidyr::expand_grid()` instead. i See <tidyverse/purrr#768>. Backtrace: x 1. \-phenoptr::count_within_many(...) at test_average_counts.R:87:3 2. \-purrr::cross(list(pair = pairs, category = category)) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is
tidyr::expand_grid()
which doesn't have these issues. The ordering of combinations is not the same, but probably not a big deal:The text was updated successfully, but these errors were encountered: