Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pluck_impl() signature #1018

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

DavisVaughan
Copy link
Member

@DavisVaughan DavisVaughan commented Dec 20, 2022

Noted on CRAN's LTO build https://www.stats.ox.ac.uk/pub/bdr/LTO/purrr.out

pluck_impl() doesn't actually use error_call at the C level. I think this was just a holdover from when we were experimenting with passing that argument through to C, but then decided on another way.

init.c:12:13: warning: type of ‘pluck_impl’ does not match original declaration [-Wlto-type-mismatch]
   12 | extern SEXP pluck_impl(SEXP, SEXP, SEXP, SEXP, SEXP);
      |             ^
pluck.c:203:6: note: type mismatch in parameter 5
  203 | SEXP pluck_impl(SEXP x, SEXP index, SEXP missing, SEXP strict_arg) {
      |      ^
pluck.c:203:6: note: type ‘void’ should match type ‘struct SEXPREC *’
pluck.c:203:6: note: ‘pluck_impl’ was previously declared here

Gabor said he has fixed the other cli -Wstrict-prototypes issue

@DavisVaughan DavisVaughan merged commit 36da3b1 into tidyverse:main Dec 21, 2022
@DavisVaughan DavisVaughan deleted the fix/pluck-signature branch December 21, 2022 14:22
DavisVaughan added a commit to DavisVaughan/purrr that referenced this pull request Dec 21, 2022
DavisVaughan added a commit that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants