-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal support for raw vectors. #455
Conversation
🤔 the failures seem related to the |
Yeah, that was my fault - can you please merge/rebase from master? |
So I have
and then I've done
I might have to properly learn about rebase some day. |
I guess I was close with my rebase attempts and all I needed really was the |
DESCRIPTION
Outdated
@@ -25,4 +25,5 @@ Suggests: | |||
VignetteBuilder: knitr | |||
LazyData: true | |||
Roxygen: list(markdown = TRUE) | |||
RoxygenNote: 6.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please use the released version of roxygen2?
Can you please also add a bullet to NEWS? |
cleaner version of #345
I think I managed to do a clean rebase this time 🎉 |
Looks good! Can you please add a bullet to NEWS? It should briefly describe the change (starting with name of the function), and crediting yourself with |
Done. Does it make sense to do the same for complex for completeness or is it a maintenance burden down the line ? |
I don't see the benefit to doing it until someone has expressed a need. |
Thanks! |
cleaner version of #345
I manually applied the changes from the broken PR to the current master