Don’t use partial matching for attr_getter() #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the `attr_getter()` fuction to no longer uses partial matching.
For example, if an `x` object has a `labels` attribute but no `label`
attribute, `attr_getter("label")(x)` will no longer extract the `labels`
attribute (fixes tidyverse#460).
Also added some documentation on the `attr_getter()` function.
|
Would you mind adding a unit test too please? |
|
OK, @hadley, I’ve now added a simple unit test that tests
|
|
Thanks! |
t-kalinowski
pushed a commit
to t-kalinowski/purrr
that referenced
this pull request
Feb 8, 2018
* Don’t use partial matching for attr_getter() * Added unit test for exact matching in attr_getter()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
attr_getter()fuction to no longer uses partial matching.For example, if an
xobject has alabelsattribute but nolabelattribute,
attr_getter("label")(x)will no longer extract thelabelsattribute (fixes #460).
Also added some documentation on the
attr_getter()function.